Add @Suite to test classes missing it#713
Merged
ktoso merged 1 commit intoswiftlang:mainfrom Apr 20, 2026
Merged
Conversation
Agent-Logs-Url: https://github.com/sidepelican/swift-java/sessions/ba01485e-36ad-4376-b9be-729bcc2de0fc Co-authored-by: sidepelican <19257572+sidepelican@users.noreply.github.com> # Conflicts: # Tests/JExtractSwiftTests/JNI/JNIIntConversionChecksTests.swift
ktoso
approved these changes
Apr 20, 2026
Collaborator
ktoso
left a comment
ktoso
left a comment
There was a problem hiding this comment.
Thanks!
Oh and, happy to take ai assisted PRs as long as authors make sure their quality is up to stuff :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While looking through the tests, I noticed that several test classes were missing the
@Suiteannotation.Since there was no clear reason for this inconsistency, I have updated the classes to ensure
@Suiteis applied consistently.Note: As a first-time experiment, I leveraged GitHub Copilot to handle the entire implementation for this PR.